search

unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

module -> package #79

Closed josh-hadley closed 3 years ago

josh-hadley commented 3 years ago

Turn ufonormalizer.py module into a package so that the _version.py file gets written to the package directory instead of the top-level site-packages. Closes #78

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.3%) to 87.879% when pulling aeb58f4f1774bd2f475fb19f2087092474328664 on josh-hadley:jh-make-package into 151d43353bdc9b68d4a01e075d9b583eef2993a0 on unified-font-object:master.

benkiel commented 3 years ago

Hey @josh-hadley just testing this, right now it's reporting the version as unknown, would it be better to not have the _version.py file gitignored?

justvanrossum commented 3 years ago

No, it should be gitignored. You have to do at least pip install -e . to have __version__ report something meaningful.

benkiel commented 3 years ago

Ok. I'll look to see how to have ufoNormalizer -h report something that makes sense.

josh-hadley commented 3 years ago

I think changing https://github.com/unified-font-object/ufoNormalizer/blob/89e6d4dfbd55f1834aee6fd537c6a4145b792dc6/src/ufonormalizer/__init__.py#L19 to

from ._version import __version__

Should resolve this.