search

unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Do not modify contents of <note> tag #86

Closed cmyr closed 3 years ago

cmyr commented 3 years ago

This changes the behaviour around normalizing the field of .glif files. Previously the contents of this element would be broken into lines and reindented, but this was a potentially destructive operation.

With this patch, any content of a element is passed through unchanged.

For more discussion, see: https://github.com/unified-font-object/ufoNormalizer/issues/85

I also note that there's a dedent_tabs method in the module. Is this used anywhere? It doesn't seem strictly related to this patch, but I also don't see it called, so maybe it can also be deleted?

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.3%) to 87.814% when pulling 757553d3ee8e3312c73454900ee37ba9436fa519 on cmyr:no-note-formatting into 186dbc1f49962c7147ac09fc7d91725734f5ff4b on unified-font-object:master.

benkiel commented 3 years ago

Thank you @cmyr!

Closes #84 Closes #85

cmyr commented 3 years ago

Thank you for accommodating me!