unifiedjs / unified-engine

Engine to process multiple files with unified
https://unifiedjs.com
MIT License
55 stars 23 forks source link

[feat] export `Configuration` for reusing #74

Closed JounQin closed 1 year ago

JounQin commented 1 year ago

Initial checklist

Problem

Configuration is used in eslint-mdx for loading remark configuration by using unified-engine/lib/configuration

https://github.com/mdx-js/eslint-mdx/blob/1ca5afd1d6e40d021d33c6f3177447e38e7263db/packages/eslint-mdx/src/worker.ts#L67-L76

It should be considered as private API path, I see we are migrating to exports field in package.json, which might make Configuration unavailable later.

Solution

export Configuration from root at the same time.

Alternatives

N/A

wooorm commented 1 year ago

Hm. I recommend PRing to expose Configuration from index.js then. With a note that says it’s mostly private, but useful for tools like eslint-mdx. Then I wont remove it when indeed going with exports

github-actions[bot] commented 1 year ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.