Closed alvinleung1996 closed 3 years ago
Why? ParseTree
is the input tree. CompileTree
is the output tree.
I'd second the why question. @alvinleung1996 do you have an example where an input or output which should be supported, is not supported?
Why?
ParseTree
is the input tree.CompileTree
is the output tree.
For the first and second overload, ParseTree
is the input tree and CompileTree
is the output tree. But for the third one, CompileTree
is the input tree and CompileTree
is the output tree, which is inconsistent with the first two overloads and is incorrect.
Ah, I misunderstood. Thanks for clarifying! I think you’re right. Care to create a pull request solving it?
Ah, I misunderstood. Thanks for clarifying! I think you’re right. Care to create a pull request solving it?
OK, I will create a pull request for it.
Initial checklist
Affected packages and versions
unified 10.1.0
Link to runnable example
No response
Steps to reproduce
The 3rd overload signature of
FrozenProcessor.run
is incorrect. https://github.com/unifiedjs/unified/blob/c3ba2cd7fce33c1133b95bc81d9b0a22dba5c409/index.d.ts#L307-L321Expected behavior
Actual behavior
Runtime
Node v16
Package manager
Other (please specify in steps to reproduce)
OS
Linux
Build and bundle tools
Webpack