Closed ChristianMurphy closed 2 years ago
Merging #182 (5414b70) into main (45b3d3f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 600 600
=========================================
Hits 600 600
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 45b3d3f...5414b70. Read the comment docs.
unifiedjs/unified-args#27 and rehypejs/rehype#82 have been opened to address the two build failures seen in the canary build
the mdx-js/mdx
build is flagging:
lib/compile.js(28,43): error TS2345: Argument of type 'VFile' is not assignable to parameter of type 'VFileCompatible'.
Type 'VFile' is not assignable to type 'VFileOptions'.
Type 'VFile' is not assignable to type '{ [key: string]: unknown; }'.
Index signature for type 'string' is missing in type 'VFile'.
lib/compile.js(42,47): error TS2345: Argument of type 'VFile' is not assignable to parameter of type 'VFileCompatible | undefined'.
Type 'VFile' is not assignable to type 'VFileOptions'.
Type 'VFile' is not assignable to type '{ [key: string]: unknown; }'.
https://github.com/unifiedjs/unified/runs/4669887032?check_suite_focus=true#step:6:52
which looks like it may be related to vfile/vfile/pull/64 /cc @remcohaszing
though it is odd that https://github.com/vfile/vfile/pull/69 should (in theory) do the same test, and didn't see on mdx-js/mdx
, it only saw it on vfile/to-vfile
:thinking:
sweet!
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/*
labels.
Initial checklist
Description of changes
Follow up to: https://github.com/unifiedjs/ideas/issues/7