unifiedjs / unified

☔️ interface for parsing, inspecting, transforming, and serializing content through syntax trees
https://unifiedjs.com
MIT License
4.49k stars 110 forks source link

Add useful error on empty presets #202

Closed wooorm closed 1 year ago

wooorm commented 2 years ago

Initial checklist

Description of changes

Empty presets are most likely a mistake by the user. At best, they do nothing. This improves the situation for humans that make mistakes, by throwing a useful error.

Closes GH-200.

github-actions[bot] commented 2 years ago

Hi team! I don’t know what’s up as there’s no phase label. Please add one so I know where it’s at.

Thanks, — bb

github-actions[bot] commented 2 years ago

Hi team! I don’t know what’s up as there’s no phase label. Please add one so I know where it’s at.

Thanks, — bb

github-actions[bot] commented 2 years ago

Hi! This is accepted and can go somewhere!

Team: please review this PR and use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this.

remcohaszing commented 2 years ago

Since this is semver major, this would also be a good time to consider other breaking changes. The first thing that comes to mind if officially dropping support for Node.js 12.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4a94722) 100.00% compared to head (77f3d97) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #202 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 596 602 +6 ========================================= + Hits 596 602 +6 ``` | [Files Changed](https://app.codecov.io/gh/unifiedjs/unified/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unifiedjs) | Coverage Δ | | |---|---|---| | [lib/index.js](https://app.codecov.io/gh/unifiedjs/unified/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unifiedjs#diff-bGliL2luZGV4Lmpz) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.