unifiedjs / unified

☔️ interface for parsing, inspecting, transforming, and serializing content through syntax trees
https://unifiedjs.com
MIT License
4.49k stars 110 forks source link

Update `typescript` #216

Closed ChristianMurphy closed 1 year ago

ChristianMurphy commented 1 year ago

Initial checklist

Description of changes

First step towards moving most or all of the types into JSDoc. Previously lack of overloads was a blocker. TypeScript 5 includes overload syntax for JSDoc https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#overload-support-in-jsdoc

The full migration to JSDoc will be large, this is the first step towards that, ensuring the project still builds on TypeScript 5, and building it with TS5 by default.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (4a94722) 100.00% compared to head (c08667b) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 596 596 ========================================= Hits 596 596 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wooorm commented 1 year ago

So this can be merged, and then TS may improve some things later in their project?

ChristianMurphy commented 1 year ago

So this can be merged, and then TS may improve some things later in their project?

That could be an option, thoughts @remcohaszing?

remcohaszing commented 1 year ago

Still this: https://github.com/unifiedjs/unified/pull/216/files#r1140496841

Updating now doesn't give us any benefits. It only means we need to apply a workaround for a regression. I'd rather delay until this regression is fixed upstream, or TypeScript adds new features that do benefit unified.

This is just a dev dependency. It doesn't matter for users.

wooorm commented 1 year ago

What’s the status of this @ChristianMurphy?

github-actions[bot] commented 1 year ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

ChristianMurphy commented 1 year ago

What’s the status of this @ChristianMurphy?

Merged, apparently 🙂