search

unify / unify

Unify Project
http://www.unifyjs.com
Other
152 stars 16 forks source link

created own touch handler #80

Closed mojoaxel closed 12 years ago

mojoaxel commented 12 years ago

fixes #75

dominikg commented 12 years ago

qx.event.handler.Touch in our qooxdoo fork was already heavily modified, i don't think you need to move it into the unify repository to add your changes. It would make maintaining it harder (upgrading qooxdoo) and we get a split history (old edits in qooxdoo fork, new ones in unify)

from what i saw in the diff, you only check for left mouse button on emulated touchstart, not on touchend.... this leaves the handler in an erroneous state if you do 1. leftmousebutton down, 2. rightmousebutton down, 3.rightmousebutton up.

  1. would cause __inTouch to become false although leftmousebutton is still down.
mojoaxel commented 12 years ago

I moved the touch handler to unify after consultation with @fastner. We think there are going to be some additional changes in the future.

About the pressed state: You got me here! I honestly thought about removing the state also but could not think about any good reason. You found one.

I'm going to change the pull request. Thx!