search

unify / unify

Unify Project
http://www.unifyjs.com
Other
152 stars 16 forks source link

"tap" event only on left mouse button #81

Closed mojoaxel closed 12 years ago

mojoaxel commented 12 years ago

fixes #75

dominikg commented 12 years ago

i'd rename the function isLeftMouseButtonPressed to isLeftMouseButton (because technically, it's not pressed anymore on mouseup...) also if you return in _onMouseEvent (which is the right place), you don't need the additional condition in __normalizeMouseEvent.

General Question: Maybe this should be configurable? What if you want to write an application that does work with the right mouse button aswell? (ok, it might be very theoretical, as the handler is mostly for touch events... maybe we should offer first class mouse support via an additional Mouse event handler?

fastner commented 12 years ago

@dominikg You can simply use the mouse handler if you need right button support.

fastner commented 12 years ago

This pull request is manually merged as the Touch handler part is moved to unify's qooxdoo fork.