This PR contains commit which includes the following:
Eslint setup
Jest setup with dummy test in niraj directory
Prettier setup for code formatting
Apart from these, I have also configured husky to ensure pre-commit and pre-push validation, which essentially means, your tests has to pass before you can commit or push code
[x] Unit Test provided - Yes
[x] Deprecated code removed? - Yes
[x] Is Syntax & Formatting correct? - Yes
[x] Is the approach to the problem appropriate? - Yes. Linting is required, and so is husky to ensure precommit validations
[x] Can anything be simplified? - No
[x] Is the code too specific to the product and needs generalization? - No. It is general enough
[ ] Do forms need to sanitized? - NA
[ ] Any obvious security flaws or potential holes? - NA
[ ] Are the naming conventions appropriate? - No. Dummy test should have been named properly. It should be removed, I kept it for husky setup validation.
[ ] Are there enough comments inline with the code? No
[x] Is there documentation needed? - No, Guideline documents are enough.
[x] Is there anything included that should not be? - No
This PR contains commit which includes the following:
Eslint setup
Jest setup with dummy test in niraj directory
Prettier setup for code formatting Apart from these, I have also configured husky to ensure pre-commit and pre-push validation, which essentially means, your tests has to pass before you can commit or push code
[x] Unit Test provided - Yes
[x] Deprecated code removed? - Yes
[x] Is Syntax & Formatting correct? - Yes
[x] Is the approach to the problem appropriate? - Yes. Linting is required, and so is husky to ensure precommit validations
[x] Can anything be simplified? - No
[x] Is the code too specific to the product and needs generalization? - No. It is general enough
[ ] Do forms need to sanitized? - NA
[ ] Any obvious security flaws or potential holes? - NA
[ ] Are the naming conventions appropriate? - No. Dummy test should have been named properly. It should be removed, I kept it for husky setup validation.
[ ] Are there enough comments inline with the code? No
[x] Is there documentation needed? - No, Guideline documents are enough.
[x] Is there anything included that should not be? - No
[x] Are all dependencies declared? - Yes
[x] Are there any code smells? - No
Let me know if you have any question