unige-geohealth / accessmod

accessmod 5 : anisotropic accessibility analysis.
GNU Lesser General Public License v3.0
42 stars 14 forks source link

Interactive map: Not possible to see the map without Raster or health facilities once a dataset has been selected #301

Open SteeveEbener opened 4 years ago

SteeveEbener commented 4 years ago

Current Behavior

Once you have selected a Raster and/or health facilities layer it is then not possible to remove these layers from the map unless you refresh the browser but in this case all the fields are back to empty

Expected Behavior

You can see the map without the raster or the health facilities layer that has been selected

Possible Solution

Add a "None" category in the "Select layer to use (raster)" and "Select facilities to use ( vector )" fields

Steps to Reproduce

  1. Select a raster layer
  2. select a health facilities layer
  3. Try to remove one of them
fxi commented 4 years ago

If the user remove selected layers from the input, layers are also removed from the map :

am_remove_layer_from_map

Doesn't this work on your side ?

SteeveEbener commented 4 years ago

Ho, ok. Got it. Not obvious at first and not intuitive + it does not seem to be explained in the user manual => might be good to add a sentence about this if it is indeed not described there.

One thing I also just noticed, is that you can also remove the basemap from the "Select basemap" field the same way as for the raster and the facilities but, in this case, the basemap in question does not disappear from the map

fxi commented 4 years ago

A base map should remain visible, even if no selection is made. But I can change this to have an empty map if the selection is not set.

If the initial issue is solved, you can close it.

Thanks

fxi commented 4 years ago

I close this issue, but you can re-open if needed.

Thanks

SteeveEbener commented 4 years ago

Just reopening it to comment that the behavior should indeed be the same across the three layers and that it might indeed be useful not to show any basemap when the computer has a slow or no internet.