search

uniiverse / apollo-tracing-ruby

[Maintainers Wanted] Ruby implementation of GraphQL trace data in the Apollo Tracing format
MIT License
85 stars 10 forks source link

Measure duration using Process.clock_gettime() rather than Time.now.utc #15

Closed jturkel closed 2 years ago

jturkel commented 6 years ago

This PR optimizes duration calculations to use Process.clock_gettime(Process::CLOCK_MONOTONIC, :nanosecond) rather than Time.now.utc. Similar optimizations landed in Benchmark in this change with a follow up simplification in this commit. On my MacBook Pro running High Sierra with a 2.2 GHz Intel Core i7 processor this speeds up a GraphQL query that returns roughly 1,089 field values from 529ms to 201ms.

jturkel commented 6 years ago

The Travis build is failing because https://registry.npmjs.org/apollo-engine-binary-darwin/-/apollo-engine-binary-linux-0.2018.4-20-g7a8822c14.tgz can't be downloaded. I assume this is unrelated to my changes.

telescopebot commented 2 years ago

Issues go stale after a week of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 2 weeks of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /lifecycle stale

telescopebot commented 2 years ago

Stale issues rot after 2 weeks of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 2 weeks of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /lifecycle rotten

telescopebot commented 2 years ago

Rotten issues close after 2 weeks of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /close

telescope-tekton[bot] commented 2 years ago

@telescopebot: Closed this PR.

In response to [this](https://github.com/uniiverse/apollo-tracing-ruby/pull/15#issuecomment-1240598257): >Rotten issues close after 2 weeks of inactivity. >Reopen the issue with `/reopen` with a justification. >Mark the issue as fresh with `/remove-lifecycle rotten` with a justification. >If this issue should be exempted, mark the issue as frozen with `/lifecycle frozen` with a justification. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.