search

uniiverse / apollo-tracing-ruby

[Maintainers Wanted] Ruby implementation of GraphQL trace data in the Apollo Tracing format
MIT License
85 stars 10 forks source link

Array Arguments Bug #8

Closed seannguyen closed 6 years ago

seannguyen commented 6 years ago

Apollo Proxy has a very annoying bug as stated in the following issues: https://github.com/apollographql/apollo-engine-js/issues/67 https://github.com/apollographql/apollo-engine-js/issues/53

Luckily, the issue has been fixed and release on apollo-engine-js side at version 2017.11-84-gb299b9188. Can we update our dependency with that fixed version and release a new version apollo-tracing-ruby.

We're looking forward to have that fix reflect here. Cheers,

seannguyen commented 6 years ago

Anw, I just sent this PR https://github.com/uniiverse/apollo-tracing-ruby/pull/9 Have a look and see if this make sense :D

exAspArk commented 6 years ago

Oh, nice! Thank you, I'll take a look soon.

We were just discussing adding an array of enums as an argument to our schema. Thankfully, we haven't faced the issue yet 😂

exAspArk commented 6 years ago

By the time when I was reading the Engine Proxy changelog yesterday, my colleagues released some GraphQL changes in our schema with the list of enums as an argument 😂 Will release a new version with the updated Proxy soon.

seannguyen commented 6 years ago

Thank guys