unikent / of-course

Of Course! is an opinionated API front-end for consuming programmes data.
Other
1 stars 1 forks source link

WIP: Show module details as well as not-running message on resting modules. #1018

Closed sy238-unikent closed 5 years ago

sy238-unikent commented 5 years ago

https://trello.com/c/QKNhtu5f/1477-module-not-running-modification

Currently a module not running in the current session just displays the module title and the message "Sorry, this module is not currently running", e.g. https://www.kent.ac.uk/courses/modules/module/art510

currentunavailablemodule

This pr displays the full modules details even if a module is not running, but replaces the delivery information block with the not running message:

unavailablemodule

vs running module:

availablemodule

To test this checkout the branch and browse to a module which is not available this year (eg /courses/modules/module/art510 )

This pr also adds a check to only display links to reading lists if links to reading lists actually exist as currently a blank link (which results in a link to the current page) is shown for reading lists if no list exists (as for current api misconfiguration)

no-reading-list becomes no-reading-list

cfc7-unikent commented 5 years ago

Looks good 👍