search

unikent / of-course

Of Course! is an opinionated API front-end for consuming programmes data.
Other
1 stars 1 forks source link

check that backend published courses = search list #383

Closed mb324-unikent closed 10 years ago

mb324-unikent commented 11 years ago

There is some concern that the publishing a course doesn't always seem to hit the api course index file in the cache, and that the search list isn't exhaustive.

We can scan the output index file that we use for the search against the list of courses in the backend, and make sure that everything that's been published is in the search.

mb324-unikent commented 11 years ago

Hi @Angelamariewatson

I found the following list of PG courses which don't appear in the index list:

Do you know if these were at some point published and then unpublished? I know we had a bug (now fixed) with the unpublish functionality which could somehow have interfered with the live status flag we use on courses. Otherwise we'd have to do a little more digging to work out why the above weren't published properly, but lots of other courses you published around the same time are just fine.

mb324-unikent commented 11 years ago

... and the following UG courses too:

aw285-unikent commented 11 years ago

Pretty sure these should all be published @jjj-unikent can you verify?

mb324-unikent commented 11 years ago

@jjj-unikent I've republished 10, 34, and 41. Let me know if you want me to do the rest.

jjj-unikent commented 11 years ago

Hi, sorry but I've been too busy to republish the others so far, but I can't see 60: Comparative Politics PhD on the front-end even though I have edited it and published today.

jjj-unikent commented 11 years ago

Also International Relations PhD (63)

jjj-unikent commented 10 years ago

Hi, I've checked all programme plant entries against output, and the definitive list of missing programmes is below:

210 Biosciences Pre-Master's GDIP (R210-1790 created 4th October 2013 at 15:55:07 by jjj)

60 Comparative Politics MA, MPhil, PhD (R60-1778 created 4th October 2013 at 11:43:06 by jjj) NB THE PDIP, MA PROGRAMME SHOWS OK

216 Critical Theory MA (R216-1137 created 14th August 2013 at 10:40:30 by jjj)

63 International Relations MA, MPhil, PhD (R63-1776 created 4th October 2013 at 11:39:22 by jjj) NB OTHER INT REL PROGRAMMES SHOW OK

144 Socio-legal studies LLM, MPhil, PhD (R144-1789 created 4th October 2013 at 14:16:23 by jjj)

314 Management MA, PhD (R314-1608 created 17th September 2013 at 10:22:41 by aw285)

Just having a look at these progs individually to see if there's anything funny about their entry that might stop them from displaying...

All the progs that aren't showing have similar names to progs that are showing - is there any chance that there might be some kind of de-duping within 'Of Course' that is causing the progs above to be filtered out of the A-Z and other lists?

jjj-unikent commented 10 years ago

Hi, Carol in our dept just reported another prog that's in the system but not showing on the front-end: 110, Intellectual and Developmental Disabilities MA, MPhil, PhD. kthxbye

jjj-unikent commented 10 years ago

Hello, Claire from American Studies just mailed to say American Studies MA, MPhil PhD is not showing (however it is present in the plant). I've tried re-saving and publishing but still not showing yet.

jjj-unikent commented 10 years ago

Update - it is showing now, following the republish : )

jjj-unikent commented 10 years ago

SSPSSR reported Sociology PhD had disappeared, I republished and it started showing again.

jjj-unikent commented 10 years ago

Just to note that this happened again today, this time for Law (International Law with International Relations), reported by Dylan in KLS.

jjj-unikent commented 10 years ago

Have been investigating and no clues yet, however something interesting has happened with Management MA, PhD

Shows 'published' icon next to title, however when you check revisions, it gives you the option to make the current revision live, so is probably not really published (Clare from KBS just reported that it is not showing on the front end)

image

image

mb324-unikent commented 10 years ago

Hi @jjj-unikent

So far as I can see we have 9 courses not showing up at the moment, although this is based on data from a couple of days ago so you might already have corrected some of these...

pg: https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/58 https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/59 https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/110 https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/144 https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/314

ug: https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/196 https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/211 https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/326 https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/333

We are totally stumped as to why this is happening. It could well be that part of the process of editing or making a course live is very occasionally timing out or having problems which means that it's not getting properly updated.

Carl is looking at an alternative way of coding the update process to make it simpler and less prone to these problems. In the meantime I'd suggest that you check that all the above courses are published.

jna-unikent commented 10 years ago

Hi

We've deployed a potential fix for this to www-test (https://github.com/unikent/programmes-plant/pull/628) and are wondering if you could somehow replicate the issue on test to check if its actually fixed?...

jjj-unikent commented 10 years ago

Hi Justice! That's good news. I don't know what causes the problem so I don't know how to replicate it. Maybe we should just roll out the fix to live and wait to see if the problem occurs again, as it does happen quite frequently. Thanks, JJ

jjj-unikent commented 10 years ago

Hi - just wondering whether that potential fix was rolled out to live? Thanks, JJ

mb324-unikent commented 10 years ago

Hi @jjj-unikent

Good news. We've finally worked out why this problem is happening! \o/

It's because you're reloading the page after you've published a course, but before it's finished publishing. This is actually a pretty reasonable thing to do because publishing takes so long. (I guess 20 secs or so?)

So to stop this happening make sure when you hit 'publish' you just leave the browser until it's all finished. I know this isn't at all ideal, but it will stop the problem happening again in the short term.

We will look tomorrow and maybe into next week at actually fixing this so that reloading the page won't break things.

Also I found the following courses are still in a broken state:

PG:

Intellectual and Developmental Disabilities https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/110 Law (Criminal Justice) https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/114 Law (International Law with International Relation... https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/131 Individualised programme of legal studies https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/135 Public International Law https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/140 Socio-legal Studies https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/144 Statistics with Finance https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/167 Architecture and Cities https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/180 Social Anthropology and Computing https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/199 International Finance and Economic Development https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/206 Advanced and Specialist Healthcare (Applied Dental... https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/215 Conservation and Rural Development https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/271 Conservation Project Management https://webtools.kent.ac.uk/programmes/2014/pg/programmes/edit/274

UG:

Psychology and Social Anthropology https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/196 European Legal Studies https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/211 Law and Criminology https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/326 Law and Philosophy https://webtools.kent.ac.uk/programmes/2014/ug/programmes/edit/333

jjj-unikent commented 10 years ago

Thanks, I have passed the info on to the rest of the team and republished all the programmes above. JJ

ghost commented 10 years ago

Hello,

I've added a fix (pending rollout) that should hopefully mitigate the effects of accidentally publishing the same revision twice: https://github.com/unikent/programmes-plant/pull/632

Although this fix should hopefully prevent the above problems reoccurring, its still best to avoid refreshing while publishing is in progress as this could still potentially cause issues with fetching modules etc.

Thanks, Carl

mb324-unikent commented 10 years ago

@jjj-unikent ok we've also now implemented a fix which should mean even if you keep pressing refresh while a course is being published, this problem won't happen. But maybe it's best not to refresh that page anyway!