Campuses form - Githubissues

unikent / programmes-plant

A comprehensive solution for the management of university programmes, that produces an XCRI feed.

Other

7 stars 4 forks source link

Closed gnozu closed 11 years ago

gnozu commented 11 years ago

There seems to be a lot of verification on the campuses form, and no indication of the rules.
When you submit the form you lose all your data if anything doesn't match the verification rules.
The save/cancel buttons aren't consistent with other forms.

conatus commented 11 years ago

This can be coded into the form itself. https://github.com/unikent/programmes-plant/blob/master/application/views/admin/campuses/form.php
It doesn't pass with data to retain information when validation fails https://github.com/unikent/programmes-plant/blob/master/application/controllers/simpleadmin.php#L159 - just add ->with_input() to this line and check we are using this on the view = done!
Campuses has a custom form - which always means trouble! Just edit this.

thybag commented 11 years ago

The not storing previous values bit (when it fails) is now fixed for all simple data by https://github.com/unikent/programmes-plant/pull/106

thybag commented 11 years ago

Its worth noting that the "School" forms also use the blue UI (like campuses). Any idea which one we want to use?

conatus commented 11 years ago

We should probably standard the buttons as a snippet to stop this happening again!

conatus commented 11 years ago

So we have a partial fix here from #106 - this is open to continue working out whether we are still standardising the forms?

conatus commented 11 years ago

Take the majority way of doing this and abstract to make sure this UI inconsistency doesn't return extending Form::ui_blah().

conatus commented 11 years ago

Abstraction for the forms themselves was done by @thybag in https://github.com/unikent/programmes-plant/pull/135 - closing.