search

unikraft / app-nettle-test

Application test for the libnettle library
Other
0 stars 1 forks source link

Transitioning app-nettle-test from lib-newlib to lib-musl #2

Open LeKog opened 1 year ago

LeKog commented 1 year ago

Pepes #1 @razvand @StefanJum
Changes to Makefile and Config.uk . No further changes were needed as it built without errors. When running I got stuck at the "Booting from ROM.." message so I could not provide further testing.

razvand commented 1 year ago

Hackathon-points: 20

LeKog commented 1 year ago

@razvand , I have made the changes that you requested. Let me know if anything else is needed.

razvand commented 1 year ago

@LeKog, when I build, both with newlib and musl, I get this error:

  CC      libnettle: arcfour-test.o
In file included from /media/razvan/c4f6765a-efa5-4ebd-9cf0-7da9908a0189/razvan/unikraft/scripts/workdir/apps/app-nettle-test/build/libnettle/origin/nettle-3.6/rsa.h:38,
                 from /media/razvan/c4f6765a-efa5-4ebd-9cf0-7da9908a0189/razvan/unikraft/scripts/workdir/apps/app-nettle-test/build/libnettle/origin/nettle-3.6/testutils.h:19,
                 from /media/razvan/c4f6765a-efa5-4ebd-9cf0-7da9908a0189/razvan/unikraft/scripts/workdir/apps/app-nettle-test/build/libnettle/origin/nettle-3.6/aes-test.c:4:
/media/razvan/c4f6765a-efa5-4ebd-9cf0-7da9908a0189/razvan/unikraft/scripts/workdir/apps/app-nettle-test/build/libnettle/origin/nettle-3.6/bignum.h:50:11: fatal error: gmp.h: No such file or directory
   50 | # include <gmp.h>
      |           ^~~~~~~

Did it happen on your side?

LeKog commented 1 year ago

@razvand , I am not getting the same error when building with either musl or newlib. In fact when I build with musl, I get no errors at all thus it builds correctly. When I build with newlib I get the error : 

  CC      libkvmplat: trace.common.o
In file included from /home/lekog/unikraft/workdir/libs/lib-newlib/include/sys/_types.h:37,
                 from /home/lekog/unikraft/workdir/apps/app-nettle-test/build/libnewlibc/origin/newlib-2.5.0.20170922/newlib/libc/include/machine/endian.h:5,
                 from /home/lekog/unikraft/workdir/apps/app-nettle-test/build/libnewlibc/origin/newlib-2.5.0.20170922/newlib/libc/include/sys/param.h:10,
                 from /home/lekog/unikraft/workdir/libs/lib-newlib/include/sys/param.h:4,
                 from /home/lekog/unikraft/workdir/unikraft/include/uk/essentials.h:48,
                 from /home/lekog/unikraft/workdir/unikraft/lib/ukdebug/include/uk/print.h:41,
                 from /home/lekog/unikraft/workdir/unikraft/plat/common/x86/trace.c:34:
/home/lekog/unikraft/workdir/libs/lib-newlib/include/uk/_types.h:44:10: fatal error: uk/time_types.h: No such file or directory
   44 | #include <uk/time_types.h>
      |          ^~~~~~~~~~~~~~~~~

This error has been discussed here [1] and I simply ignored it as the whole point is to not use newlib but musl.

[1] : https://github.com/unikraft/lib-newlib/issues/29