unikraft / app-python3

Unikraft Python3 app repo
12 stars 9 forks source link

kraft.yaml: Use stable version for all components #7

Closed razvand closed 2 years ago

razvand commented 2 years ago

This has the benefit of not requiring updates whenever there is a new version release of Unikraft components.

razvand commented 2 years ago

Firstly, app-python3 uses functions from posix-event(/home/X/apps/app-python3/build/libpython3/origin/Python-3.7.4/Modules/timemodule.c:1843: undefined reference to select), so we need to add - CONFIG_LIBPOSIX_EVENT=y to the kraft.yaml file.

This lib-python3 PR needs to be integrated first. Use that. It will fix things.

Secondly, the app doesn't seem to work on the stable branch of Unikraft. This due to issue unikraft/unikraft#529, which is fixed by commit unikraft/unikraft@9bf6e63 found only on the staging branch.

Apart from that, everything seems fine to me.

Ah, damn. Please see if changing stable to 9bf6e63 fixes it. Or, if not, using staging. I will then update kraft.yaml accordingly. Then we'll make a note for future update of kraft.yaml to stable.

eduardvintila commented 2 years ago

This lib-python3 PR needs to be integrated first. Use that. It will fix things.

Oops, didn't see that PR. Yes, makes sense now.

Ah, damn. Please see if changing stable to 9bf6e63 fixes it. Or, if not, using staging. I will then update kraft.yaml accordingly. Then we'll make a note for future update of kraft.yaml to stable.

Yes, simply changing the version to staging(or 9bf6e63) seems to do the job.

razvand commented 2 years ago

Yes, simply changing the version to staging(or 9bf6e63) seems to do the job.

I fixed the PR. Please see now, @eduardvintila .