search

unikraft / app-redis

Redis on Unikraft
5 stars 12 forks source link

Fix command for manually running redis #6

Closed mariasfiraiala closed 1 year ago

mariasfiraiala commented 2 years ago

Signed-off-by: Maria Sfiraiala maria.sfiraiala@gmail.com

mariasfiraiala commented 2 years ago

Alright then, closing this PR. I'll take a look into the documentation for lib-redis.

razvand commented 2 years ago

Hi, @mariasfiraiala . Based on our discussion, this PR is indeed useful. We require a redis.conf configuration file to be passed to Redis, and that needs to be done via a filesystem (such as 9pfs).

Please update this commit with the fs0/redis.conf file.

This redis.conf file worked for me, maybe you can simplify it:

bind 172.44.0.2
port 6379
tcp-backlog 511
timeout 0
tcp-keepalive 300
razvand commented 2 years ago

Also add instructions on adding 9pfs support with the proper tag (rootfs in the command above), similar to the lib-nginx documentation. You could also add this to the lib-redis repository for consistency.

I think consistency is important, so I would aim to make Redis and Nginx as close to each other as possible, documentation-wise.

mariasfiraiala commented 2 years ago

Only one comment, looks good besides that.

Thank you @StefanJum . Removed it.

razvand commented 2 years ago

@mariasfiraiala , please mark solved items with Resolve conversation and re-request reviews from reviewers (@StefanJum in this case).