unikraft / dynamic-apps

Pre-built Dynamic Linux ELFs
7 stars 36 forks source link

Grep: Add grep dynamic executable #71

Closed chococandy63 closed 1 year ago

chococandy63 commented 1 year ago

Add the grep command of the grep command line utility. Document usage of the grep command in README.md.

chococandy63 commented 1 year ago

Hello @StefanJum I have made the necessary changes requested by you, kindly check!

chococandy63 commented 1 year ago

@StefanJum Thank you for the reviews, I have made the changes. Hopefully, everything is fine this time :)

chococandy63 commented 1 year ago

@StefanJum I pushed new changes(new commit) to the remote repository but I don't know how it got merged with this grep commit. Could you please guide me through this?

StefanJum commented 1 year ago

@chococandy63 first make a copy, make sure you have everything saved in case we mess something up. Then:

git rebase -i HEAD~3 # <-- this will open a text editor with the commits
                                      # remove the line with the `file` commit (the lasts one probably)
                                      # save and exit

git log # <-- the `file` commit should be gone
git push --force
chococandy63 commented 1 year ago

@StefanJum Thank you! Looks fine to me, Can you please review this PR?