`kraft pkg pull` no longer works with GitHub sources

craciunoiuc commented 11 months ago

Describe the bug

In previous versions of kraft, commands like this used to work:

kraft pkg pull github.com/unikraft/lib-nginx.git
W  could not get index: GET https://github.com/v2/unikraft/lib-nginx.git/manifests/latest: unexpected status code 404 Not Found: Not Found
W  could not find github.com/unikraft/lib-nginx.git
E  no processes to perform

Steps to reproduce

run kraft pkg update
run kraft pkg pull github.com/unikraft/lib-nginx.git

Expected behavior

Library is pulled in the path: .unikraft/libs/<libname>

Which architectures were you using or does this bug affect?

x86_64

Which operating system were you using or does this bug affect?

linux/debian

Relevant log output

No response

unsuman commented 9 months ago

I've been trying to solve this issue recently and have some inquiries on my mind. Is it similar to the functionality of git clone? Could you offer alternative resources or links beyond what's provided in the documentation that can be used with kraft pkg pull?

craciunoiuc commented 9 months ago

There are two methods, ssh and http

With ssh, it's only git, with http it's archive + git.

Git-way means it uses a go-git library to fetch sources with history. Archive-way means you just fetch files for a given tag/branch like you would do from the github UI.

craciunoiuc commented 3 months ago

status update:

This happens because the package name needs to be used and that one does not match the url provided, so further investigation is needed

unikraft / kraftkit