search

unikraft / kraftkit

Build and use highly customized and ultra-lightweight unikernel VMs.
https://unikraft.org/docs/cli
BSD 3-Clause "New" or "Revised" License
213 stars 61 forks source link

Notarization workflow fails because of keychain access #1198

Open craciunoiuc opened 5 months ago

craciunoiuc commented 5 months ago

Describe the bug

Notarization as a workflow currently fails because certificates are saved into the default keychain.

This guide should be followed to allow notarizing from a no-prompt environment: https://federicoterzi.com/blog/automatic-code-signing-and-notarization-for-macos-apps-using-github-actions/

Note: Notarization seems to be optional in our case, still we should ensure this works properly if we want to revisit in the future.

Steps to reproduce

No response

Expected behavior

No response

Which architectures were you using or does this bug affect?

No response

Which operating system were you using or does this bug affect?

No response

Relevant log output

No response

amroKerkizz commented 3 months ago

Hi Im a student at the University of Texas at Austin, and for a project we were assigned I would like to work on this issue. I was wondering if this issue could be assigned to me?

craciunoiuc commented 3 months ago

Hey @amroKerkizz, this is something a bit more on the internal side that we need to handle and it's not really urgent.

For the context of virtualization I think you should look for something else

craciunoiuc commented 3 weeks ago

Notarization workflow will be disabled starting the next release, no need to continue this until we decide to enable it back

Will leave issue open to track it