search

unikraft / kraftkit

Build and use highly customized and ultra-lightweight unikernel VMs.
https://unikraft.org/docs/cli
BSD 3-Clause "New" or "Revised" License
225 stars 63 forks source link

kraft progress bar for pull operation stays at 0% then jumps to 100% at end (ie, shows no progress) #1380

Open felipehuici opened 6 months ago

felipehuici commented 6 months ago

Describe the bug

kraft progress bar for pull operation stays at 0% then jumps to 100% at end (ie, shows no progress)

Steps to reproduce

Any kraft run cmd (see relevant log output for example)

Expected behavior

Progress bar shows different percentage as pull operation progresses

Which architectures were you using or does this bug affect?

x86_64

Which operating system were you using or does this bug affect?

macOS

Relevant log output

% kraft run --rm -p 8080:8080 --plat qemu --arch x86_64 -M 256M
 W  using hardware emulation
 i  using arch=x86_64 plat=qemu
[+] pulling unikraft.org/php:8.2 (qemu/x86_64) •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 0% [56s]
craciunoiuc commented 6 months ago

This is a bit harder to do, as the pull detects if it's an OCI archive or a regular git repos/links after the progress bar was provided.

This is relevant because for github repos/links it works so it's not easy to disable progress only OCI

We'll do this later

craciunoiuc commented 2 weeks ago

Did an extensive look, this is not possible for OCI and HTTPS cloning, it will only partially work for SSH cloning

The fix here should be to remove the progress bar altogether for pulling unfortunately