feat(run): Allow application args overriding from CLI - Githubissues

unikraft / kraftkit

Build and use highly customized and ultra-lightweight unikernel VMs.

https://unikraft.org/docs/cli

BSD 3-Clause "New" or "Revised" License

203 stars 61 forks source link

feat(run): Allow application args overriding from CLI #1694

Open LucaSeri opened 3 weeks ago

LucaSeri commented 3 weeks ago

Passing arguments from the CLI directly overrides any commands from the Kraftfile or Dockerfile. The first argument of kraft run is the context and any subsequence argument is considered an application argument.

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[x] Updated relevant documentation.

Description of changes

Closes: #1614

LucaSeri commented 1 week ago

@nderjung turns out all the runners besides one(the one I was mostly using) were already doing this, and in the last runner, the runner.args just happened to be omited.