unikraft / lib-musl

musl: A C standard library
Other
8 stars 27 forks source link

patches: Fix ioctl signature in function definition #44

Closed StefanJum closed 1 year ago

StefanJum commented 1 year ago

The ioctl() function signature was changed in commit 2848305 to use an unsigned long as a second argument, in order to match the definition in Linux, glibc and our own implementation. The function definition however was not changed, leading to build errors due to function signature conflict.

RaduNichita commented 1 year ago

It seems to be working now. Thanks @StefanJum for providing this quick fix!

Reviewed-by: Radu Nichita radunichita99@gmail.com

eduardvintila commented 1 year ago

@StefanJum, this PR gets musl back on its feet again, thanks a lot for this! @rares-miculescu, please take a look so we can merge this.