search

unikraft / lib-newlib

Unikraft port of newlib, a C standard library
Other
5 stars 23 forks source link

lib-newlib: Update sigset_t structure to 1024 bits just as in musl #15

Closed dragosargint closed 2 years ago

dragosargint commented 2 years ago

This PR changes the sigset_t structure from newlib to 1024 bits to solve conflicts that occur between musl and newlib when linked with uk_signal. Musl uses a 1024-bit mask, and newlib uses a 64-bit mask (i.e. an unsigned long).

This PR is part of a group that aims to solve compiling errors for both musl and newlib:

dragosargint commented 2 years ago

Done!

marcrittinghaus commented 2 years ago

I don't get why a second definition of __sigset_t in lib-newlib has been introduced in the first place. But this is not your fault. Although, I think it would be better to clean up this mess, I will approve this change when all PRs in the series are ok.

marcrittinghaus commented 2 years ago

So coming from the discussion in our community meeting, we should keep the definition in lib-newlib the same. Sorry for proposing the change in the first place but I only now get the whole picture with the other PRs referenced.

However, we should still remove the duplicate definition of is_sig_dfl etc. when introducing it in <uk/signal.h> as suggested in https://github.com/unikraft/unikraft/pull/326. But let us have a discussion on the whole PR series first.

razvand commented 2 years ago

This is superseded.