search

unikraft / pykraft

Python library for configuring and building unikernels
Other
177 stars 42 forks source link

Create application with name from `kraft.yaml` #83

Closed gabrielmocanu closed 2 years ago

gabrielmocanu commented 2 years ago

Describe the bug Right now when you build an application it will use the name convention from the parent directory of that application, instead of using the name from kraft.yaml. This bug also caused this problem #80 .

To Reproduce Steps to reproduce the behavior: 1.git@github.com:unikraft/app-helloworld.git

  1. cd app-helloworold
  2. kraft configure -p kvm -m x86_64
  3. kraft build

Expected behavior After building an application with the name example from kraft.yaml, the unikernel executable should have the name example_kvm-x86-64 even though the parent directory where this application has a different name.

Screenshots Screenshot from 2021-10-30 13-56-53

Desktop (please complete the following information):

Additional context

gabrielmocanu commented 2 years ago

@StefanJum

Can this issue be closed since this PR was merged?

StefanJum commented 2 years ago

@StefanJum

Can this issue be closed since this PR was merged?

Yes, we should close this.