search

unimailrocks / unimail

unimail makes world domination happen
0 stars 0 forks source link

Allow moving items *into* nested containers #44

Open rivertam opened 7 years ago

rivertam commented 7 years ago

This might be extremely difficult and require a refactor... Let's find out.

rivertam commented 7 years ago

From Jon:

From Slack:

first, the break. Here are the steps to replicate: 1 Create two containers near each other but not nested 2 Put a smaller container in one of those 3 Shift to move the smaller container to the other container 4 Resize the container that has the nested container and then put it inside of the other container 5 Draw a container that encompasses both 6 Add an image to the outermost container 7 Resize the outermost container I got this when I followed those steps (which, once moved away, was totally fine and didn’t break the rules again)

screen shot 2017-05-23 at 10 08 38 am

you can see that I managed to get one on the outside of the other. I know that what I did here is very, very far from a normal use case — it’s just a question of whether there’s any busted logic. Also, this was hard to do — I couldn’t replicate it again (although I can make the inner containers jump a lot on resizing — they’ll move around more significantly than I would expect when I drag the edge of the larger container)

rivertam commented 7 years ago

@jonsurfs I can't reproduce this, but it might be because I'm having a lot of trouble reproducing step 3. That's definitely an issue...

jonsurfs commented 7 years ago

Just move the inner to a no container area and then back in. Does that work?

On Tue, May 23, 2017, 11:17 AM Ben Berman notifications@github.com wrote:

@jonsurfs https://github.com/jonsurfs I can't reproduce this, but it might be because I'm having a lot of trouble reproducing step 3. That's definitely an issue...

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/unimailrocks/unimail/issues/44#issuecomment-303431693, or mute the thread https://github.com/notifications/unsubscribe-auth/AFwWbptPrMZg6jiVTdcc0MzK0w-crTNiks5r8vhtgaJpZM4NaoCG .

rivertam commented 7 years ago

Yeah that's what I was doing when I couldn't reproduce. I'm more concerned about the issue with #3 than the issue you're reporting, tbh. Although they're both very concerning.

rivertam commented 7 years ago

well actually I guess I'm more concerned with your issue bc it won't be renderable