unimelb / design-system-issues

Issues repo for the Unviersity's Digital Design System
0 stars 0 forks source link

[BUG] Warning button isn't red enough #14

Closed catherinehunt closed 4 years ago

catherinehunt commented 4 years ago

The colour of the warning button is very tasteful and on-brand, but doesn’t really say ‘warning’ to me. At least on my monitor, it displays as quite brown. Ditto for the "danger" notice class.

Expected behaviour

Red-coloured button

Current behaviour

Red-brown button (russet??)

Steps to reproduce

<a class="button warning">Warning</a>

Affected browsers

jaredhenderson commented 4 years ago

Hi @catherinehunt, you're spot on about the colour - it's actually the Orange Dark from our digital colour palette as we don't have any reds! Was before my time so I can't explain the reasoning for that.

Anyway, I completely agree and I think for the sake of clarity that we can make an exception in this case. Top button pictured below uses an updated red.

Screen Shot 2019-11-07 at 2 26 54 pm

@makenosound this is probably the third time I've asked you to change this one, sorry

tomstringer commented 4 years ago

This one also needs a bit more attention.

Red works ok on buttons, though the current hover state probably needs review (currently #984140).

Notices have both warning and danger classes: https://web.unimelb.edu.au/components/notices/

Red background on danger looks a bit hectic.

Screen Shot 2019-11-19 at 1 24 33 pm

jaredhenderson commented 4 years ago

@tomstringer cool, let's address the button itself here and I'll re-jig the notice ticket to resolve the other issues. I've amended my comment above with an additional value for the hover background colour.