Closed ptagell closed 10 years ago
I would like to raise the question, should header/footer be in the repo at all (beyond documentation)? They're not components that can be used by the user and they will need to be compiled to a standalone JS/CSS package.
I think that's a good question. Ideally, I'd like to empower the whole community to suggest changes to global elements as well as local ones. This is true open source. Also, I think it's important that the CSS / JS used to power the global nav, footer etc is bundled into the same minified / cdnified codebase to reduce requests.
All that being said, there are several complexities that I think may be difficult to overcome:
Open to suggestions. Can we choose several files, very specific components, from the asset tree to be rendered into a seperate injection.js file? Even the structure of Injection.js is less than desirable with all of it's embedded and escaped html - is there a more elegant way to do this?
Happy to meet to discuss this - set something up if you think we need to thrash this out face to face.
Good points. What if we had another directory...
/templates <-- for all things part of the template
/injection <-- for header/footer stuff
Then the release process is that everything in the templates directory is deployed in a versioned manner, where everything in the injections directory is deployed in an clobbering manner.
Ok, I feel like this has been resolved offline. @neilang is it safe to close this one?
Safe :+1:
Coming across an issue that I think we need to discuss.
Can we create a list of components that will be injected (and centrally controlled) vs. elements that will be added via local sites.
At the moment, looking at the templates site, I think the following will likely be injected:
Is that it? All the styles are obviously centrally held, but the example files in these components will need to be the production code that is made available. Perhaps we need a production.slim file for those components that will be rolled into some sort of injection?
My questions:
Thoughts?