unimelb / unimelb-design-system

A complete design system for the University of Melbourne
https://web.unimelb.edu.au
30 stars 12 forks source link

Hide 3rd party embeds at page load #745

Closed waitingallday closed 8 years ago

waitingallday commented 8 years ago

Including an iframe inside a modal (not advised anyway) can sometimes cause the iframe content to peek above page content at pageload: this PR will hide it with CSS.

Interestingly, this was caused by the bug "fix" for IE8 in v3.1 that moved the modal DOM relocation to the click event. Before then, the modals were outside the page container and couldn't peek above.