unimelb / unimelb-design-system

A complete design system for the University of Melbourne
https://web.unimelb.edu.au
30 stars 12 forks source link

No minimum width on Course Header pages MCE (after minimizing screen width past 1415px) #759

Open jporich opened 7 years ago

jporich commented 7 years ago

Expected behaviour

Minimum padding on left of Course Header (Page Layouts) in MCE (see screenshot)

Not sure if this is a design decision or not (would have though not!)

no-min-padding

Actual behaviour

~1415px screen width, the left padding of course header goes responsive to 0 :(

Steps to reproduce

Minimize screen to 1415px wide, notice no min padding

dkevey commented 7 years ago

@jporich what browser are you viewing this in? Works ok for me in Chrome on Mac.

Also a reminder to paste in URL's so we can easily look.

https://resources.web.unimelb.edu.au/controlled-environment/templates/special/course-filtered-list/music/certificate-in-excellence

jporich commented 7 years ago

Ooops!

Sorry Donna, I’m viewing this one in Chrome Version 54.0.2840.98 (64-bit)

Also my browser zoom is at 100% (I know this has caused some wiggy issues in the past)

Jimmy Porich | Web Content and Development Coordinator External Relations | University Services

Level 2, 32 North Lincoln Square The University of Melbourne, Victoria 3010 Australia T: (03) 9035 8072 E: james.porich@unimelb.edu.aumailto:james.porich@unimelb.edu.au

[cid:image001.png@01D23F23.1ACFB1B0]

This email and any attachments may contain personal information or information that is otherwise confidential or the subject of copyright. Any use, disclosure or copying of any part of it is prohibited. The University does not warrant that this email or any attachments are free from viruses or defects. Please check any attachments for viruses and defects before opening them. If this email is received in error please delete it and notify us by return email.

From: Donna notifications@github.com Reply-To: marcom-unimelb/unimelb-design-system reply@reply.github.com Date: Tuesday, 15 November 2016 at 9:30 am To: marcom-unimelb/unimelb-design-system unimelb-design-system@noreply.github.com Cc: Jimmy Porich jporich@gmail.com, Mention mention@noreply.github.com Subject: Re: [marcom-unimelb/unimelb-design-system] No minimum width on Course Header pages MCE (after minimizing screen width past 1415px) (#759)

@jporichhttps://github.com/jporich what browser are you viewing this in? Works ok for me in Chrome on Mac.

Also a reminder to paste in URL's so we can easily look.

https://resources.web.unimelb.edu.au/controlled-environment/templates/special/course-filtered-list/music/certificate-in-excellence

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/marcom-unimelb/unimelb-design-system/issues/759#issuecomment-260484494, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJmqKnazVO_msNqnYebycXJN0jjVGM6sks5q-ODsgaJpZM4Kw2-B.

axelboc commented 7 years ago

Seems like the problem is that the course-select class is set on a form element instead of a simple div. @dkevey Is this component used somewhere with the drop-down on the right like here: https://web.unimelb.edu.au/components/headers/#course-header-short ? If not, then just switch the form to a div.

axelboc commented 7 years ago

It's actually caused by a Matrix override, so if the form element is required then maybe just modify that override to exclude .course-select as well:

#top.uomcontent form:not(.unstyled-controls):not(.filtered-listing-select) {
    padding-left: 0;
    padding-right: 0;
}