unimelb / unimelb-design-system

A complete design system for the University of Melbourne
https://web.unimelb.edu.au
30 stars 12 forks source link

Headings 4 to 6 aren't differentiable enough from body text #904

Open rhyslawry opened 7 years ago

rhyslawry commented 7 years ago

Expected behaviour

Readers usually expect headings to be either larger, more prominent, or at least differentiable from the body/paragraph text beneath them. It should be obvious to a reader what is a heading and what is not.

Actual behaviour

In the new Design System, headings 4, 5 and 6 are either smaller or the same size as paragraph text, and don't have enough bottom padding. This doesn't look great, and leads to confusion for readers. https://web.unimelb.edu.au/components/base/#typography-styles

I've found editors avoiding h4 to h6s due to their sizes/styles, and are using less logical heading levels purely for their appearances.

In the old pre-2014 design system (as still visible on http://about.unimelb.edu.au) headings 4 to 6 are much easier to visually differentiate from body text.

On closer inspection I think the main issue is that <h4> is exactly the same size as <p>, and h4 to h6 have no bottom padding.

Summary of issues:

Steps to reproduce

image

image

Compare with the sizes and top/bottom padding of Github headings:

Heading 1

Body text

Heading 2

Body text

Heading 3

Body text

Heading 4

Body text

Heading 5

Body text

Heading 6

Body text

axelboc commented 7 years ago

Yes! 💯% yes!

dkevey commented 7 years ago

I vote for this one too and have also found that H3 is not much better than simply bolding the text.