unimelb / unimelb-design-system

A complete design system for the University of Melbourne
https://web.unimelb.edu.au
30 stars 12 forks source link

Button-small with icon has wrong right padding inside div class="half" (two columns) #910

Open rhyslawry opened 7 years ago

rhyslawry commented 7 years ago

Expected behaviour

Buttons (specifically button-small) with icons should display the same inside the two column layout <div class="half"> as they do in single column layout.

Actual behaviour

If a button-small with an icon is used inside a div class="half", the button's right padding is off (Or the icon is displaying too far to the right... I can't work out which) The following code: <p><a class="button-small" href="./?a=2090656" target="_blank">2017 Melbourne Law Masters Prospectus (PDF 6.3MB)<span class="small" data-icon="download"></span></a> </p> Is on this page: http://law.unimelb.edu.au/study/masters

Screenshots

The following two screenshots are the exact same page, one has the <div class="half"> and in the other it is removed.

Button-small with icon in single-column layout: (OK) icon-button-ok

Button-small with icon in two-column layout: (Broken) icon-button-not-ok