unimelb / unimelb-design-system

A complete design system for the University of Melbourne
https://web.unimelb.edu.au
30 stars 12 forks source link

images misaligned in news articles #921

Closed dcollett closed 6 years ago

dcollett commented 6 years ago

Expected behaviour

Images using the new figure component within align correctly using v7 of the design system

Actual behaviour

Images using the new figure component within are misaligned

Steps to reproduce

See: https://le.unimelb.edu.au/news/mooc-of-the-month-september-2017/

This page uses the old figure class and aligns as expected: https://le.unimelb.edu.au/news/designing-for-learning-with-technology-may-workshops/

Note this site is using a custom WP theme with V 7.0 of DDS

axelboc commented 6 years ago

The image doesn't seem to be loading. Here it is with a placeholder:

screen shot 2017-09-22 at 9 16 29 am

The alignment of figures inside the news-single component has indeed changed between v6 and v7. The change brings more consistency to the design of both the news-single and event page components. Notably, all figures now behave the same way, whether they contain images or video embeds.

dcollett commented 6 years ago

Oops. Should be there now.

axelboc commented 6 years ago

Ah I see, the problem is the size of the image. Any chance you could find a wider version? Needs to be at least 985px.

dcollett commented 6 years ago

Here's an example with a wider version: https://le.unimelb.edu.au/news/get-ready-for-the-semester-2-subject-experience-survey-ses/ I guess I'm expecting it to resize to the column width, as opposed to overflowing, like the examples on https://web.unimelb.edu.au/components/figure/ screen shot 2017-09-22 at 11 07 26 am

& good to know that a min width is required. I'll make sure they're 1000px+

dcollett commented 6 years ago

Hey Axel, it's not a bug so I'll close this. As you say the width of the image is the issue. Might be worth updating the caption on the image on this page: https://web.unimelb.edu.au/components/news/#news-single It gave me the impression that 700px was OK as a min image width. That image is 1600px wide. cheers, Dean

axelboc commented 6 years ago

Ah yeah, well spotted! Will open a new issue, thanks.