WIP — New branding - Githubissues

TimMansell commented 5 years ago

General improvements for rebrand:

use px and convert to rem where needed
use margin-bottom only for spacing so components align to top easier
not relying on any CMS related classes. ie, .uomcontent so it's easier to use elsewhere
IE11+ support. Remove custom CSS for <IE11
remove dependency on ruby. Utilise node based solution to generate documentation. Served as static markup would be ideal
linting (eslint) CSS and JS (based on pattern-lib config) - may need configuring.
netlify to serve github PR previews of changes
update package.json dependencies & presets (babel) etc
vertical rthym variable for consistent margin/padding values
remove floats and utilitse flexbox if possible
line-height unitless value
remove use of magic numbers where possible
media queries should only be nested inside the class they're meant to change. Don't wrap many classes in a single media query.

makenosound commented 5 years ago

@TimMansell Thanks for the notes, have made all those changes now!

makenosound commented 5 years ago

This work has been merged into a separate repository: https://github.com/unimelb/Gen3

unimelb / unimelb-design-system