search

unimonkiez / react-native-svg-loader

Build time parsing for svgs, use any svg in your React Native app in ease
12 stars 4 forks source link

fill does not work on svgs without the fill property #2

Open chitezh opened 6 years ago

chitezh commented 6 years ago

Most of my SVGs are without the fill property so no way to set "replace". The browser and react-native-vector-icons are able to fill properly.

Note: My SVGs are transformed automatically by metro so I don't ever get to see it

unimonkiez commented 6 years ago

In css if you set color the the svg element, even inner paths within in inherit that color.
In react-native it's all programmable, so I figure a way to "replace" those paths' fill color..

chitezh commented 6 years ago

Maybe add an option like the fillall prop in https://github.com/vault-development/react-native-svg-uri/commit/c6f3e87f566b158b1df2a06f87bc7b318f19926a

unimonkiez commented 6 years ago

That's sounds easy to do, I'll try to get to it after my exams.
Or maybe you can do it in a PR 🙄