Open noklam opened 1 year ago
I haven't made any PR to pandera
before, if this direction is correct I could try to make a PR, but I would like to get some feedback first. Please advise what tests are needed and potentially where should I add them.
The PR description and approach is good! Basically we need to:
Sounds good! I will try to finish it this week, if not I will be back in mid Oct.
I just have a quick look, does pandera have something like GitPod or Github Codespace for CDE development? If not I can also create a separate PR to add support for GitPod and maybe add this into the contribution guide as an alternative to build locally.
They have a open source program https://www.gitpod.io/discover/opensource
I think github codespace should just work out of the box, not sure how it installs the virtual environment tho
Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. In 0.16.0,
PANDERA_VALIDATION_ENABLED
was added to disable runtime check. I want to apply the flag to pandas DataFrame as well.Describe the solution you'd like A clear and concise description of what you want to happen. The decorator style of validation is convenient but there are no way to turn it off easily and it introduces runtime cost. The feature already exist for PySpark, and I want it for pandas DataFrame as well.
Currently, only PySpark is respecting this configuration: https://github.com/unionai-oss/pandera/blob/5a15cb1e7508743608a181d5a0f35949e200c2ff/pandera/api/pyspark/container.py#L327-L339
Potentially, the logic can be added for pandas https://github.com/unionai-oss/pandera/blob/5a15cb1e7508743608a181d5a0f35949e200c2ff/pandera/api/pandas/container.py#L284-L286
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.