Closed cosmicBboy closed 1 month ago
Hi @cosmicBboy, thank you for your extremely fast response and solution! :)
For us it would work without problems as we don't use these generic types.
However if I understand correctly there is a tradeoff because this may introduce silent bugs in somebody else's code. Imagine something like this:
Another thing in the case you decide to proceed the requirements.in file, shouldn't be changed as well? setting typeguard >= 2.13.3
Pandera now works different and if the code is not very well tested this may go unnoticed.
Will add a warning so that the behavior is more transparent
Hi @cosmicBboy , thank you for the prompt solution. With this change, would Series[TYPE]
gets affected as well or it is just LIST[TYPE]
and DICT[TYPE, TYPE]
?
E.g.
from pandera.typing import DataFrame, Series
class DataFrameSchema(pa.DataFrameModel):
Index: Series[pa.Int]
TimeStamp: Series[pa.Timestamp]
Value: Series[pa.Float]
TimeSeries = DataFrame[DataFrameSchema]
Hi @cosmicBboy , thank you for the prompt solution. With this change, would Series[TYPE] gets affected as well or it is just LIST[TYPE] and DICT[TYPE, TYPE]?
Just the typing
module types
This PR loosens the typeguard version dependency to support version < 3. Addresses the comment here: https://github.com/unionai-oss/pandera/issues/1365#issuecomment-2047026850