Adding function to create contrast for bg color, modify tests

unional / aurelia-logging-color

Colorful appender for aurelia-logging

MIT License

2 stars 3 forks source link

Adding function to create contrast for bg color, modify tests #4

Closed srshah19 closed 7 years ago

srshah19 commented 7 years ago

This PR includes:

Creating a function to generate complementary colors
Compare background and foreground to have minimum contrast ratio. IF not, switch to either black/white.
Modify tests based on these changes
Minor spelling fix

fixes #4

unional commented 7 years ago

Thank! Can you fix the lint errors? If you use vscode, you can use the tslint extension and fix most issue using the auto fix feature.

srshah19 commented 7 years ago

Sure. I will fix via vscode and update the PR. Thanks

srshah19 commented 7 years ago

Hi @unional, I tried fixing all lint errors and locally all tests pass when I run npm run test and npm run verify. colors-map I know is a dependency that needs to be npm installed. Any suggestions on what i might be missing for the build to be successful?

unional commented 7 years ago

That is strange. Looks like some issue with latest npm/webpack. Checking on it.

unional commented 7 years ago

Besides the strange error, I also notice your CSSBrush is still in 4 spaces. Can you change it to 2 spaces? 🌷

unional commented 7 years ago

I have fixed the problem. Please update your branch and try again.

The issue started related to the new npm and coveralls issue and quite a few others.

srshah19 commented 7 years ago

Thanks @unional. I'll update the branch right now.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling fdc4964227e29033ef8d2c831909621531037cee on srshah19:gen-color into 75c4763c1e4171692d9c2411fdf4cc994926c03b on unional:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling f457952218cb36ea783e004a463348c574be0b8b on srshah19:gen-color into 75c4763c1e4171692d9c2411fdf4cc994926c03b on unional:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling f457952218cb36ea783e004a463348c574be0b8b on srshah19:gen-color into 75c4763c1e4171692d9c2411fdf4cc994926c03b on unional:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling f457952218cb36ea783e004a463348c574be0b8b on srshah19:gen-color into 75c4763c1e4171692d9c2411fdf4cc994926c03b on unional:master.

unional commented 7 years ago

Again, thanks for the contribution. And about the IDE setting, I created this to see if there is a better solution: https://github.com/palantir/tslint/issues/2939

srshah19 commented 7 years ago

Thank you! Very proud of my first contribution to an open source project! 💯