unionco / calendarize

Calendar Field Type for CraftCMS
MIT License
18 stars 14 forks source link

After Query doesn't return multi-day events in the past #72

Open laurabennett opened 2 years ago

laurabennett commented 2 years ago

Similar to the problem with upcoming but slightly different.

I have an event for July 2-4, 2021 (now in the past) and another event July 23 - Aug 1. Plus a number of single day recurring events that seem to work as expected.

If I query for events after July 1, the future multi-day event displays but the July 2-4 event does not. If I query for events between July 1 and July 30 both events display as expected.

{% if endDate is not empty %} {% set events = craft.calendarize.between(startDate, endDate, { section: ['events'] }, order, unique) %} {% else %} {% set events = craft.calendarize.after(startDate, { section: ['events'] }, order, unique) %} {% endif %}

laurabennett commented 2 years ago

Is this plugin no longer being supported? It does so much of what I need but a few issues with date filtering are causing it to be unusable for what we need to use it for.

fvaldes33 commented 2 years ago

@laurabennett - It was our intention to continue supporting this plugin but it has been very difficult with other client work in our way. If you can send me the exact details of the event date, times and recurring rules I can try to reproduce the issue and push a fix.

laurabennett commented 2 years ago

Thanks!! Here is my dev site.

http://dev.settlersgreen.drivedev.net/events

  1. There is an event scheduled for 10/6 which only displays if I use an end date in the filter rather than leaving it empty. I have 10/5/21 as the start date. This is also the case if the event is "today" rather than "yesterday".
  2. Multi-day event 10/9-10/10, If I select 10/10 as the start date to show events it does not display.

Let me know if you need my filter code or any other test data.

On Wed, Oct 6, 2021 at 8:45 PM Franco Valdes @.***> wrote:

@laurabennett https://github.com/laurabennett - It was our intention to continue supporting this plugin but it has been very difficult with other client work in our way. If you can send me the exact details of the event date, times and recurring rules I can try to reproduce the issue and push a fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/unionco/calendarize/issues/72#issuecomment-937353427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYJKJVD7W7RCBPM23DJTL3UFTUULANCNFSM5AQG4EUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Laura Bennett digital diva

drive > P.O. Box 2838, 170 Kearsarge Street North Conway, NH 03860 603.356.3030 @.***

laurabennett commented 2 years ago

Any update on this? I did try looking into the code myself but it looks like a loop... I don't see where the actual date comparison occurs.

On Thu, Oct 7, 2021 at 9:23 AM Laura Bennett @.***> wrote:

Thanks!! Here is my dev site.

http://dev.settlersgreen.drivedev.net/events

  1. There is an event scheduled for 10/6 which only displays if I use an end date in the filter rather than leaving it empty. I have 10/5/21 as the start date. This is also the case if the event is "today" rather than "yesterday".
  2. Multi-day event 10/9-10/10, If I select 10/10 as the start date to show events it does not display.

Let me know if you need my filter code or any other test data.

On Wed, Oct 6, 2021 at 8:45 PM Franco Valdes @.***> wrote:

@laurabennett https://github.com/laurabennett - It was our intention to continue supporting this plugin but it has been very difficult with other client work in our way. If you can send me the exact details of the event date, times and recurring rules I can try to reproduce the issue and push a fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/unionco/calendarize/issues/72#issuecomment-937353427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYJKJVD7W7RCBPM23DJTL3UFTUULANCNFSM5AQG4EUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Laura Bennett digital diva

drive > P.O. Box 2838, 170 Kearsarge Street North Conway, NH 03860 603.356.3030 @.***

--

Laura Bennett digital diva

drive > P.O. Box 2838, 170 Kearsarge Street North Conway, NH 03860 603.356.3030 @.***

laurabennett commented 2 years ago

Help?? This is still an issue. At this point we will likely need to transfer our calendar to a different plugin.