unionlabs / union

The trust-minimized, zero-knowledge bridging protocol, designed for censorship resistance, extremely high security, and usage in decentralized finance.
https://union.build
Apache License 2.0
60 stars 11 forks source link

Remove individual rust clippy and test jobs #1234

Open benluelo opened 7 months ago

benluelo commented 7 months ago

Given how our codebase has grown, it no longer makes sense to run clippy on each individual package. We should instead have one check that runs cargo clippy --workspace -- -D warnings (and similar for tests).

Steps

Start with the clippy merge first, we will need to evaluate whether the tests are worth merging into one derivation.

Resources

The crane docs are quite thorough: https://crane.dev/; feel free to ping me if you have any questions!

PoisonPhang commented 7 months ago

One advantage to keeping these separate is with the new CI workflow from #1218, we'd only re-evaluate clippy and test for outputs who's nar hash has changed. I may be mistaken though, if any workspace member triggers a change in the nar hash, then my point it mute.

benluelo commented 7 months ago

Yeah I was thinking about that as well, but another benefit we get from doing this is clippy gets run on the entire repo without having to specify an output for every lib/bin/etc.