search

unionlabs / union

The trust-minimized, zero-knowledge bridging protocol, designed for censorship resistance, extremely high security, and usage in decentralized finance.
https://union.build
Apache License 2.0
72 stars 16 forks source link

unify timestamp handling throughout the stack #1822

Open benluelo opened 5 months ago

benluelo commented 5 months ago

currently, we define timestamps as multiple different types:

https://github.com/unionlabs/union/blob/f92cc97a00f3a45988621fa1480c2784806cf757/lib/unionlabs/src/traits.rs#L152-L153 https://github.com/unionlabs/union/blob/f92cc97a00f3a45988621fa1480c2784806cf757/lib/unionlabs/src/traits.rs#L310-L312

this should be unified to a type that handles nanos properly. we can likely reuse the protobuf defined timestamp type: https://github.com/unionlabs/union/blob/main/lib/unionlabs/src/google/protobuf/timestamp.rs

benluelo commented 1 month ago

not marking this as E-easy since this touches a significant portion of the repo