unionups / ember-cli-bootstrap-sass

Include bootstrap-sass and bootstrap-for-ember into an ember-cli app
19 stars 12 forks source link

Deploy to Heroku #5

Closed amedrz closed 10 years ago

amedrz commented 10 years ago

Hi guys,

When deploying to Heroku everything seems to be OK but once I try to load the app in the browser I'm getting:

Uncaught TypeError: undefined is not a function

I narrowed down my dependencies and realized that's because of ember-cli-bootstrap-sass

Any ideas of why? Not sure if there's a workaround for this.

Thanks!

unionups commented 10 years ago

Root of the problem is the following Ember.Handlebars.compile in bootstrap-for-ember . In production ember-cli builds with handlebars.runtime.js which doesn't have .compile. In the next version (0.8.0) of bootstrap-for-ember will be removed need for Handlebars.runtime.js ( #87 ). Аs a workaround include the full version of Handlebars and not only runtime. Read more: addon breaks other addons #22

unionups commented 10 years ago

Аs a workaround include the full version of Handlebars and not only runtime.

This is somewhat non-standard and discouraged, but suppose that due to a requirement in your application that you need to use the full version of Handlebars even in the production environment. You would simply provide the path to the EmberApp constructor:

 var app = new EmberApp({
   vendorFiles: {
     'handlebars.js': {
       production: 'bower_components/handlebars/handlebars.js'
     }
   }
 });
amedrz commented 10 years ago

Thanks @unionups but it didn't work for me, the same problem persisted... My workaround was use broccoli-sass along with bootstrap-sass-official instead