This PR makes diff.py write back the original lines (before placeholders have been inserted) to testsuite-result.json when they are accepted in review mode.
The code for loading and processing of the test suite results has been refactored into a class-based approach to reduce the amount of noise when iterating over them in CommandDiffer.diff_command_results().
After merging #289, we should do a manual pass where we run the test suite and replace testsuite-result.json with the resulting new_testsuite_log.json to restore all values replaced by placeholders. This has no effect on the actual tests, but makes it easier for us to search through the log to find specific IPs, MACs, etc.
This PR makes diff.py write back the original lines (before placeholders have been inserted) to
testsuite-result.jsonwhen they are accepted in review mode.The code for loading and processing of the test suite results has been refactored into a class-based approach to reduce the amount of noise when iterating over them in
CommandDiffer.diff_command_results().After merging #289, we should do a manual pass where we run the test suite and replace
testsuite-result.jsonwith the resultingnew_testsuite_log.jsonto restore all values replaced by placeholders. This has no effect on the actual tests, but makes it easier for us to search through the log to find specific IPs, MACs, etc.