Parsing serial numbers from Windows seems to fail for some machines

unioslo / nivlheim

A system for collecting key information from all your servers and presenting it through an easy-to-use web GUI with search and browse functions. The previous generation of this system is used in production at the University of Oslo, Norway.

GNU General Public License v3.0

9 stars 7 forks source link

Parsing serial numbers from Windows seems to fail for some machines #126

Closed oyvindhagberg closed 4 years ago

oyvindhagberg commented 5 years ago

This code for parsing serial numbers seems to fail for some machines: https://github.com/usit-gd/nivlheim/blob/b47fdca021fb0f458abd12feb401a2ac7d51c2a5/server/service/parseFiles.go#L344-L358

[x] Add more error checking and logging, don't just silently skip errors
[x] Test with production data from machines where it doesn't work
[x] Do the same for adjacent blocks of code that work in a similar fashion

oyvindhagberg commented 5 years ago

Parsing serial numbers seems to fail for macOS too, see:
https://nivlheim02.uio.no/#/browsehost/5A3985C26DCEABCB66403CA9A395E12B48015917

Note that a different piece of code does the parsing for macOS.

oyvindhagberg commented 5 years ago

False alarm. The code already logs errors: https://github.com/usit-gd/nivlheim/blob/b47fdca021fb0f458abd12feb401a2ac7d51c2a5/server/service/parseFiles.go#L61-L72
Parsing serial numbers on Windows works now, I am unable to reproduce that error.