search

unipept / unipept-database

Makes database tables and indices for Unipept
MIT License
0 stars 2 forks source link

Replace makefile and configure with single run script #19

Closed ninewise closed 3 years ago

ninewise commented 3 years ago

Since make does not remove intermediate files during execution, we were using up a lot more space than required. The new script fixes the order of execution. This allows removing intermediate files during execution. On the downside, this makes it more work to build only parts of the database.

ninewise commented 3 years ago

Oh I searched for usages, but my searcher skips hidden files. I'll have a look.

ninewise commented 3 years ago

I've made some changes so I could use the script for the static database, too.

Is there a specific reason the build_database.sh workflow script is a separate script and not just inlined in the yml file?

pverscha commented 3 years ago

I initially did not inline build_database.sh in the yml-file for debugging purposes (so that I didn't have to run the GitHub-action locally, which is actually possible using this repository, but takes a long time...). I guess, however, that we can decide to inline the script at this point in time :)

ninewise commented 3 years ago

OK, I inlined it now - let's hope we don't have to debug again.