search

unipop-graph / unipop

Data Integration Graph
Apache License 2.0
204 stars 35 forks source link

0.2/optimized properties #43

Closed seanbarzilay closed 8 years ago

seanbarzilay commented 8 years ago

31

rmagen commented 8 years ago

Bulk querying comes up in most of our Step implementations, and currently we just duplicate the code. Besides the obvious want for reuse, we also need a simple way to configure the different bulk sizes and bulking behaviors (e.g. Incrementing bulk size).

  1. Maybe create a helper class for all of this?
  2. Or maybe replace all these steps with a UniBulkStep (extends AbstractStep), that receives an instance of a UniqueryHandler (our current Steps will become UniqueryHandlers (or a more fitting name..)). This will also enable us to have a simple inheritance structure between the UniQueryHandlers, solving the remaining code duplication (PredicatesHolder, proertyKeys, returnClass, etc).
seanbarzilay commented 8 years ago

Fixed Properties strategy Deleted UniGraphVertexPropertiesSideEffectStep since it is no longer needed Implemented UniBulkStep and converted steps to use it