search

uniquetruth / remote-debug-agent

a useful java agent for integration testing
Apache License 2.0
71 stars 25 forks source link

被测应用是dubbo2.x ，注入报错 #30

Closed yang-yao closed 1 year ago

yang-yao commented 1 year ago

如果被测应用是dubbo2.x，注入agent的时候，org/apache/dubbo/remoting/exchange/Request.getData() 找不到 我看代码，是在DubboVisitor里面，方法进入的时候调用了 dubbo3.x的方法，是否要做一下兼容

@Override
protected void onMethodEnter() {
         mv.visitVarInsn(Opcodes.ALOAD, 1);
         mv.visitVarInsn(Opcodes.ALOAD, 2);
         mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL,
            "org/apache/dubbo/remoting/exchange/Request",
            "getData",
            "()Ljava/lang/Object;", false);
uniquetruth commented 1 year ago

本来是有兼容的，但确实是这个方法改漏了。 fixed by 4a279d8d5184705b15c831bb8cf86e2d2e7cb133 请使用master分支的最新代码

uniquetruth commented 1 year ago

thank you for your report.