search

uniqush / uniqush-push

Uniqush is a free and open source software system which provides a unified push service for server side notification to apps on mobile devices.
http://uniqush.org
Apache License 2.0
1.53k stars 201 forks source link

Update method to disallow different fixed data psp under the same push service type for a service #201

Closed victorlang closed 5 years ago

victorlang commented 6 years ago

Based on the comments from TysonAndre. Update method to disallow different fixed data psp under the same push service type for a service. Updated pull request for #198

victorlang commented 6 years ago

@TysonAndre please review the code change above again.

victorlang commented 6 years ago

@TysonAndre Thank you for review and commit the updated change above. About the message to fix issue. Since that's a common method used not only for APNS service, I update some words according to your comments. Please double check the commit above. Thanks!

vclang commented 6 years ago

@TysonAndre could you help review and merge the changes above? thanks

TysonAndre commented 5 years ago

This has been merged with patches for code style, review comments, as well as adding a (previously absent) simple unit test for the pushdb module and the new functionality

See https://github.com/uniqush/uniqush-push/commits/cfc71ea4b9f90dc0f149a7ad62d4c0cd8ff6ce9f